Move HttpClient and SocketClient to separate legacy section#57
Merged
WyriHaximus merged 1 commit intoreactphp:mainfrom Aug 7, 2021
Merged
Move HttpClient and SocketClient to separate legacy section#57WyriHaximus merged 1 commit intoreactphp:mainfrom
WyriHaximus merged 1 commit intoreactphp:mainfrom
Conversation
WyriHaximus
approved these changes
Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset rearranges the component sections and moves the legacy HttpClient and legacy SocketClient to a separate legacy components section. Additionally, I've merged the network and protocol components into a single section to clean up the component overview.
I consider this to be reasonable first step to put less emphasis on our legacy components. In a follow-up PR we should eventually remove these components from the website (but special care should be taken to still include old releases in the changelog and set up appropriate redirects for existing links).
Old:
New:
Refs reactphp/http-client#152 and reactphp-legacy/socket-client#95